-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Fix .llm import trigger of .distributed depr warning
#10512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
rusty1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that will prevent the warning since you still depend on torch_geometric.distributed.
im confused, where do you see the warning on your end. I tested importing pyg and dont see any warnings |
|
you don't see them since DeprecationWarnings are not shown by default. It is visible in |
is there a quick way to turn that on for interactive debugging? |
|
just call the warning as |
for more information, see https://pre-commit.ci
okay since we still use local graph/feature store i put the warnings where most would see them for initializing loaders because if your doing that you would probably benefit from using cugraph instead. hopefully this works for you. lmk if you recommend another way |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rusty1s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we need the warning in all three places?
No description provided.